Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4229C11721 for ; Tue, 9 Sep 2014 22:32:24 +0000 (UTC) Received: (qmail 33308 invoked by uid 500); 9 Sep 2014 22:32:24 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 33267 invoked by uid 500); 9 Sep 2014 22:32:24 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 33256 invoked by uid 99); 9 Sep 2014 22:32:23 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Sep 2014 22:32:23 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 7EB518529; Tue, 9 Sep 2014 22:32:23 +0000 (UTC) From: madrob To: dev@curator.apache.org Reply-To: dev@curator.apache.org References: In-Reply-To: Subject: [GitHub] curator pull request: CURATOR-144: TreeCache.Builder to configure ... Content-Type: text/plain Message-Id: <20140909223223.7EB518529@tyr.zones.apache.org> Date: Tue, 9 Sep 2014 22:32:23 +0000 (UTC) Github user madrob commented on the pull request: https://github.com/apache/curator/pull/41#issuecomment-55046217 Minor: before committing to master, I think it would be good to either squash everything into a single commit or edit the commit messages to all include the associated JIRA. Not sure if there is an adopted project wide policy relating to this though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---