curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kpe <...@git.apache.org>
Subject [GitHub] curator pull request: discovery: registration of wrong/old service...
Date Thu, 11 Sep 2014 13:17:16 GMT
GitHub user kpe opened a pull request:

    https://github.com/apache/curator/pull/43

    discovery: registration of wrong/old service instance on RECONNECT

    ```ServiceDiscoveryImpl.registerService()``` remembers service registrations in a map.
However ```updateService()``` does not update the map. 
    This causes a wrong registration in the case of a RECONNECT - e.g. ```reRegisterServices()```
called by the ```ConnectionStateListener``` registers the old ```ServiceInstance``` instead
of the updated one.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kpe/curator master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit 8d9d247d2eb9a29f9c9d4343fa7f6869d43441dc
Author: kpe <kpe.git@gmailbox.org>
Date:   2014-09-11T13:09:45Z

    fix for updateService() not keeping the service instance, causing an old registration
in reRegisterServices() in the case of reconnection

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message