curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <...@git.apache.org>
Subject [GitHub] curator pull request: ChildData's path check prevents the creation...
Date Fri, 19 Sep 2014 04:59:25 GMT
Github user madrob commented on the pull request:

    https://github.com/apache/curator/pull/45#issuecomment-56135351
  
    Very cool, thanks. Based on your test failure, I ran a git bisect and confirmed that the
issue came from commit 05254afe - exactly the one where I added all of the validation. Don't
know why it didn't get caught right away... probably missed a maven clean or something like
that.
    
    It seems like there are two possible solutions here - remove the null check (which you
did), or change NULL_CHILD_DATA to not use a null path (maybe empty string is acceptable here?).
It looks like there is nothing special about the object being used, it's just a placeholder.
I think I prefer the the second solution, because then users are still protected from undefined/unexpected
behaviour, like NPE if they call compareTo().
    
    Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message