curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-144: TreeCache.Builder to configure ...
Date Mon, 01 Sep 2014 03:12:53 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/41#discussion_r16939659
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java
---
    @@ -580,13 +670,33 @@ public Void apply(TreeCacheListener listener)
         }
     
         /**
    -     * Default behavior is just to log the exception
    -     *
    -     * @param e the exception
    +     * Send an exception to any listeners, or else log the error if there are none.
          */
    -    protected void handleException(Throwable e)
    +    private void handleException(final Throwable e)
         {
    -        LOG.error("", e);
    +        if ( errorListeners.size() == 0 )
    +        {
    +            LOG.error("", e);
    +        }
    +        else
    +        {
    +            errorListeners.forEach(new Function<UnhandledErrorListener, Void>()
    +            {
    +                @Override
    +                public Void apply(UnhandledErrorListener listener)
    +                {
    +                    try
    +                    {
    +                        listener.unhandledError("", e);
    +                    }
    +                    catch ( Exception e )
    +                    {
    +                        LOG.error("Exception handling exception", e);
    +                    }
    +                    return null;
    +                }
    +            });
    +        }
    --- End diff --
    
    I don't think that funneling unhandled errors through the CuratorFramework's listeners
would work super well. Because there's not going to any real way of identifying where they
came from, beyond logging them, I'm not sure what else you could do with them.
    
    Maybe attaching UnhnadlerErrorListener's to each recipe is the way to go.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message