Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
Date: Mon, 11 Aug 2014 21:40:14 +0000 (UTC)
From: "Mike Drob (JIRA)" <jira@apache.org>
To: dev@curator.apache.org
Message-ID: <JIRA.12733338.1407788840442.58524.1407793214328@arcas>
In-Reply-To: <JIRA.12733338.1407788840442@arcas>
References: <JIRA.12733338.1407788840442@arcas>
Subject: [jira] [Commented] (CURATOR-139) Add slf4j logging implementation
 to test scope
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CURATOR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093340#comment-14093340 ] 

Mike Drob commented on CURATOR-139:
-----------------------------------

The log output was ~6M, which doesn't strike me as a big deal. The total runtime on my (not that powerful) laptop changed by less than a minute, which I assume is just variance. Sanity check looks good from my end.

> Add slf4j logging implementation to test scope
> ----------------------------------------------
>
>                 Key: CURATOR-139
>                 URL: https://issues.apache.org/jira/browse/CURATOR-139
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Mike Drob
>
> When attempting to debug unit tests, it can be very difficult because the no-op logger is used as the default slf4j implementation. We should add a test scoped log4j (or logback, doesn't really matter) dependency so that test output is saved.
> Reasons against are that it potentially slows down the tests because of extra IO or that it uses up a non-trivial amount of disk space. If either of these is the case, I feel that they should be addressed separately. Logging can be specifically configured for the cases where we have known issues.


--
This message was sent by Atlassian JIRA
(v6.2#6252)