Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2BC8411953 for ; Wed, 20 Aug 2014 21:15:29 +0000 (UTC) Received: (qmail 73297 invoked by uid 500); 20 Aug 2014 21:15:29 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 73257 invoked by uid 500); 20 Aug 2014 21:15:29 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 73245 invoked by uid 99); 20 Aug 2014 21:15:29 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Aug 2014 21:15:29 +0000 Date: Wed, 20 Aug 2014 21:15:29 +0000 (UTC) From: "Jordan Zimmerman (JIRA)" To: dev@curator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (CURATOR-136) Invalid LeaderLatch path never errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-136. -------------------------------------- Resolution: Fixed > Invalid LeaderLatch path never errors > ------------------------------------- > > Key: CURATOR-136 > URL: https://issues.apache.org/jira/browse/CURATOR-136 > Project: Apache Curator > Issue Type: Bug > Components: Recipes > Affects Versions: 2.6.0 > Reporter: John Vines > Assignee: Jordan Zimmerman > Fix For: 2.7.0 > > > I was messing with the LeaderLatch and I noticed some ill behavior for the pathing of it. Given the following code- > {code} public static void main(String args[]) throws Exception { > TestingServer ts = new TestingServer(); > CuratorFramework curator = CuratorFrameworkFactory.builder().connectString(ts.getConnectString()).retryPolicy(new ExponentialBackoffRetry(1000, 5)).build(); > curator.start(); > curator.getZookeeperClient().blockUntilConnectedOrTimedOut(); > curator.create().creatingParentsIfNeeded().forPath("/parent", "A string".getBytes()); > > try { > LeaderLatch ll = new LeaderLatch(curator, "parent", "myNode"); > ll.start(); > ll.await(); > System.out.println(ll.hasLeadership()); > ll.close(); > } catch (Exception e) { > e.printStackTrace(); > } > ts.close(); > } > {code} > the system will just hang forever. Inspecting the TestingServer with zkcli shows entries showing up though. > If I switch out the path in the LeaderLatch constructor with "/parent", the same path is created AND the program runs fine. > LeaderLatch should either accept the path all around or fail outright, not this half state that makes things difficult for the user. -- This message was sent by Atlassian JIRA (v6.2#6252)