Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: dragonsinth <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-41-curator@git.apache.org>
In-Reply-To: <git-pr-41-curator@git.apache.org>
Subject: [GitHub] curator pull request: CURATOR-144: TreeCache.Builder to
 configure ...
Content-Type: text/plain
Message-Id: <20140828164135.98EB3A04811@tyr.zones.apache.org>
Date: Thu, 28 Aug 2014 16:41:35 +0000 (UTC)

Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/41#discussion_r16851772
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java ---
    @@ -461,11 +546,16 @@ public void close()
          *
          * @return listenable
          */
    -    public ListenerContainer<TreeCacheListener> getListenable()
    +    public Listenable<TreeCacheListener> getListenable()
    --- End diff --
    
    It's just a surface area reduction.  Returning Listenable only allows a caller to add and remove listeners (which you want).  Returning the subtype ListenableContainer would let a caller manipulate the collection, i.e. size(), clear(), and forEach().  How weird would it be for an external caller to be able to do `cache.getListenable().forEach(...)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---