curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-71 do not log-and-throw
Date Fri, 01 Aug 2014 17:48:36 GMT
GitHub user madrob opened a pull request:

    https://github.com/apache/curator/pull/31

    CURATOR-71 do not log-and-throw

    If we throw an exception, then there is no point in logging it since
    something further up the call stack already has to deal with it. At
    best, the exception gets logged twice, at worst we log potentially
    confusing exceptions that end up not mattering.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madrob/curator CURATOR-71

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 35278cc1b52802995ee5db017bcc84dba7c69a70
Author: Mike Drob <mdrob@cloudera.com>
Date:   2014-08-01T17:08:47Z

    CURATOR-71 do not log-and-throw
    
    If we throw an exception, then there is no point in logging it since
    something further up the call stack already has to deal with it. At
    best, the exception gets logged twice, at worst we log potentially
    confusing exceptions that end up not mattering.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message