curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-144) TreeCache should use a builder for advanced options
Date Thu, 28 Aug 2014 14:52:09 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113814#comment-14113814
] 

ASF GitHub Bot commented on CURATOR-144:
----------------------------------------

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/41#discussion_r16843905
  
    --- Diff: curator-client/src/main/java/org/apache/curator/utils/CloseableExecutorService.java
---
    @@ -116,7 +116,7 @@ public CloseableExecutorService(ExecutorService executorService)
          */
         public CloseableExecutorService(ExecutorService executorService, boolean shutdownOnClose)
         {
    -        this.executorService = executorService;
    +        this.executorService = Preconditions.checkNotNull(executorService);
    --- End diff --
    
    Add a message to the checkNotNull. It helps in debugging. The canonical form is:
    
    ```java
    foo = Preconditions.checkNotNull(foo, "foo cannot be null");
    ```


> TreeCache should use a builder for advanced options
> ---------------------------------------------------
>
>                 Key: CURATOR-144
>                 URL: https://issues.apache.org/jira/browse/CURATOR-144
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>            Reporter: Scott Blum
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message