curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-141) Avoid confusing error logging when PathChildrenCache and curator client are closed.
Date Thu, 14 Aug 2014 12:17:11 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096905#comment-14096905
] 

ASF GitHub Bot commented on CURATOR-141:
----------------------------------------

GitHub user karel1980 opened a pull request:

    https://github.com/apache/curator/pull/37

    CURATOR-141 Don't make calls to the client after PathChildrenCache has been closed

    The test case is a bit weird because it needed to intercept logging.
    Also, I've added slf4j-log4j12 as a test dependency to control logging.
    I think it should be added to the other poms as well, otherwise logging
    seems to get lost.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karel1980/curator CURATOR-141

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit f2f1953c544398cb6db53a2ac59b02719cc83fa3
Author: Karel Vervaeke <karel@ngdata.com>
Date:   2014-08-14T11:46:03Z

    CURATOR-141 Don't make calls to the client after PathChildrenCache has been closed.
    
    The test case is a bit weird because it needed to intercept logging.
    Also, I've added slf4j-log4j12 as a test dependency to control logging.
    I think it should be added to the other poms as well, otherwise logging
    seems to get lost.

----


> Avoid confusing error logging when PathChildrenCache and curator client are closed.
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-141
>                 URL: https://issues.apache.org/jira/browse/CURATOR-141
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.6.0
>            Reporter: Karel Vervaeke
>             Fix For: 2.7.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> See this message on the list:
> http://mail-archives.apache.org/mod_mbox/curator-user/201408.mbox/%3CCAA5C_ptEzXbBRrmq5HmBsSmjyzbn6vD1E8tXMixufySbyvRNgw%40mail.gmail.com%3E
> PathChildrenCache instances should not make calls to the curator client after they have
been closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message