curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-141) Avoid confusing error logging when PathChildrenCache and curator client are closed.
Date Fri, 15 Aug 2014 05:46:18 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098204#comment-14098204
] 

ASF GitHub Bot commented on CURATOR-141:
----------------------------------------

Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/37#issuecomment-52276174
  
    Fix looks good to me, as does the test. I won't merge the request quite yet though as
I'm unsure of the POM changes. While they look ok to me, I'm a complete Maven newbie and I'm
not sure if these dependencies should be pulled in in another way. Presumably the build is
picking up the slf4j libraries already given that the code uses them?


> Avoid confusing error logging when PathChildrenCache and curator client are closed.
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-141
>                 URL: https://issues.apache.org/jira/browse/CURATOR-141
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.6.0
>            Reporter: Karel Vervaeke
>             Fix For: 2.7.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> See this message on the list:
> http://mail-archives.apache.org/mod_mbox/curator-user/201408.mbox/%3CCAA5C_ptEzXbBRrmq5HmBsSmjyzbn6vD1E8tXMixufySbyvRNgw%40mail.gmail.com%3E
> PathChildrenCache instances should not make calls to the curator client after they have
been closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message