curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-141) Avoid confusing error logging when PathChildrenCache and curator client are closed.
Date Mon, 18 Aug 2014 11:52:19 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100556#comment-14100556
] 

ASF GitHub Bot commented on CURATOR-141:
----------------------------------------

Github user karel1980 commented on the pull request:

    https://github.com/apache/curator/pull/37#issuecomment-52482025
  
    It should be pointed out that the scope of the slf4j-log4j12 dependency is 'test' so it
only affects the tests.
    Without this, no slf4j binding is present during the test which causes logging to be incompletely
set up.
    You can see this by the messages in target/surefire-reports/*-output.txt:
    
        SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
        SLF4J: Defaulting to no-operation (NOP) logger implementation
        SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    
    Unfortunately revisiting this I noticed that the 'Just checking' message for verifying
the slf4j setup fails to break the test when the slf4j binding is removed from the pom. Not
what I wanted. I'm having a closer look to see what goes wrong and how it can be improved.


> Avoid confusing error logging when PathChildrenCache and curator client are closed.
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-141
>                 URL: https://issues.apache.org/jira/browse/CURATOR-141
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.6.0
>            Reporter: Karel Vervaeke
>             Fix For: 2.7.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> See this message on the list:
> http://mail-archives.apache.org/mod_mbox/curator-user/201408.mbox/%3CCAA5C_ptEzXbBRrmq5HmBsSmjyzbn6vD1E8tXMixufySbyvRNgw%40mail.gmail.com%3E
> PathChildrenCache instances should not make calls to the curator client after they have
been closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message