curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-139) Add slf4j logging implementation to test scope
Date Mon, 11 Aug 2014 21:38:12 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093335#comment-14093335
] 

ASF GitHub Bot commented on CURATOR-139:
----------------------------------------

GitHub user madrob opened a pull request:

    https://github.com/apache/curator/pull/36

    CURATOR-139 Add slf4j-log4j test bindings

    Add test bindings so that log output is preserved. Makes it easier to
    debug jenkins and failed unit tests, which not appreciably increasing
    the time to run or disk space used.
    
    This closes #36

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madrob/curator CURATOR-139

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 104837d0739647729eef58f7d2dc29c3fb62f89e
Author: Mike Drob <mdrob@cloudera.com>
Date:   2014-08-11T21:34:33Z

    CURATOR-139 Add slf4j-log4j test bindings
    
    Add test bindings so that log output is preserved. Makes it easier to
    debug jenkins and failed unit tests, which not appreciably increasing
    the time to run or disk space used.
    
    This closes #36

----


> Add slf4j logging implementation to test scope
> ----------------------------------------------
>
>                 Key: CURATOR-139
>                 URL: https://issues.apache.org/jira/browse/CURATOR-139
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Mike Drob
>
> When attempting to debug unit tests, it can be very difficult because the no-op logger
is used as the default slf4j implementation. We should add a test scoped log4j (or logback,
doesn't really matter) dependency so that test output is saved.
> Reasons against are that it potentially slows down the tests because of extra IO or that
it uses up a non-trivial amount of disk space. If either of these is the case, I feel that
they should be addressed separately. Logging can be specifically configured for the cases
where we have known issues.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message