curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-71) Error message in StandardLockInternalsDriver for retryable lock acquire error
Date Fri, 01 Aug 2014 17:49:39 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082604#comment-14082604
] 

ASF GitHub Bot commented on CURATOR-71:
---------------------------------------

GitHub user madrob opened a pull request:

    https://github.com/apache/curator/pull/31

    CURATOR-71 do not log-and-throw

    If we throw an exception, then there is no point in logging it since
    something further up the call stack already has to deal with it. At
    best, the exception gets logged twice, at worst we log potentially
    confusing exceptions that end up not mattering.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madrob/curator CURATOR-71

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 35278cc1b52802995ee5db017bcc84dba7c69a70
Author: Mike Drob <mdrob@cloudera.com>
Date:   2014-08-01T17:08:47Z

    CURATOR-71 do not log-and-throw
    
    If we throw an exception, then there is no point in logging it since
    something further up the call stack already has to deal with it. At
    best, the exception gets logged twice, at worst we log potentially
    confusing exceptions that end up not mattering.

----


> Error message in StandardLockInternalsDriver for retryable lock acquire error
> -----------------------------------------------------------------------------
>
>                 Key: CURATOR-71
>                 URL: https://issues.apache.org/jira/browse/CURATOR-71
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.1.0-incubating
>            Reporter: Vegard B. Havdal
>
> We occasionally get the error message "Sequential path not found..." from StandardLockInternalDriver,
but the subsequent NoNode exception is caught and treated as normal in some cases in LockInternals.
Ie. bogus error message in our log.
> Consider removing the error log msg from StandardLockInternalDriver, not log and throw.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message