curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-144: TreeCache.Builder to configure ...
Date Thu, 28 Aug 2014 14:51:13 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/41#discussion_r16843905
  
    --- Diff: curator-client/src/main/java/org/apache/curator/utils/CloseableExecutorService.java
---
    @@ -116,7 +116,7 @@ public CloseableExecutorService(ExecutorService executorService)
          */
         public CloseableExecutorService(ExecutorService executorService, boolean shutdownOnClose)
         {
    -        this.executorService = executorService;
    +        this.executorService = Preconditions.checkNotNull(executorService);
    --- End diff --
    
    Add a message to the checkNotNull. It helps in debugging. The canonical form is:
    
    ```java
    foo = Preconditions.checkNotNull(foo, "foo cannot be null");
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message