curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jojovilco <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-84 More flexibility for InterProcess...
Date Tue, 19 Aug 2014 07:09:50 GMT
Github user jojovilco commented on the pull request:

    https://github.com/apache/curator/pull/38#issuecomment-52597742
  
    Yes, you are correct. 
    
    Indeed in default lock implementation it can be done by watching connection. But not in
other custom lock implementations which this issue aims to target. I would make access to
lockPath protected, to be managed by lock implementation itself. Public access can mislead
the purpose. E.g. is it ok to directly delete the path to release the lock? No! There is different
API for that.
    
    For me, it is more intuitive to reason about lost lock from watching the actual lockPath
node, than derive its existence from lost connection. But this is, off course, subjective.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message