curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karkum <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-84 More flexibility for InterProcess...
Date Mon, 18 Aug 2014 13:50:38 GMT
Github user karkum commented on a diff in the pull request:

    https://github.com/apache/curator/pull/38#discussion_r16353602
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/InterProcessMutex.java
---
    @@ -61,7 +61,17 @@ private LockData(Thread owningThread, String lockPath)
          */
         public InterProcessMutex(CuratorFramework client, String path)
         {
    -        this(client, path, LOCK_NAME, 1, new StandardLockInternalsDriver());
    +        this(client, path, new StandardLockInternalsDriver());
    +    }
    +
    +    /**
    +     * @param client client
    +     * @param path the path to lock
    +     * @param driver lock driver
    +     */
    +    private InterProcessMutex(CuratorFramework client, String path, LockInternalsDriver
driver)
    --- End diff --
    
    Yes, I was just about to comment back. The plan was for a client using the ```InterProcessMutex```
to specify their own ```LockInternalsDriver``` with different parameters than the one provided
by the default ```StandardLockInternalsDriver```. We definitely need this to be public. 
    
    I'm not sure what you mean by "Also LockInternalsDriver would need to be public?". Could
you please elaborate? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message