curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-84 More flexibility for InterProcess...
Date Mon, 18 Aug 2014 13:43:58 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/38#discussion_r16353274
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/InterProcessMutex.java
---
    @@ -61,7 +61,17 @@ private LockData(Thread owningThread, String lockPath)
          */
         public InterProcessMutex(CuratorFramework client, String path)
         {
    -        this(client, path, LOCK_NAME, 1, new StandardLockInternalsDriver());
    +        this(client, path, new StandardLockInternalsDriver());
    +    }
    +
    +    /**
    +     * @param client client
    +     * @param path the path to lock
    +     * @param driver lock driver
    +     */
    +    private InterProcessMutex(CuratorFramework client, String path, LockInternalsDriver
driver)
    --- End diff --
    
    Sorry for the previous comment, but this, actually, needs to be public right? Also LockInternalsDriver
would need to be public? The issue seeks to have nodes created with PERMANENT. Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message