curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karel1980 <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-141 Don't make calls to the client a...
Date Mon, 18 Aug 2014 11:50:47 GMT
Github user karel1980 commented on the pull request:

    https://github.com/apache/curator/pull/37#issuecomment-52482025
  
    It should be pointed out that the scope of the slf4j-log4j12 dependency is 'test' so it
only affects the tests.
    Without this, no slf4j binding is present during the test which causes logging to be incompletely
set up.
    You can see this by the messages in target/surefire-reports/*-output.txt:
    
        SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
        SLF4J: Defaulting to no-operation (NOP) logger implementation
        SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    
    Unfortunately revisiting this I noticed that the 'Just checking' message for verifying
the slf4j setup fails to break the test when the slf4j binding is removed from the pom. Not
what I wanted. I'm having a closer look to see what goes wrong and how it can be improved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message