curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-141 Don't make calls to the client a...
Date Fri, 15 Aug 2014 05:44:52 GMT
Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/37#issuecomment-52276174
  
    Fix looks good to me, as does the test. I won't merge the request quite yet though as
I'm unsure of the POM changes. While they look ok to me, I'm a complete Maven newbie and I'm
not sure if these dependencies should be pulled in in another way. Presumably the build is
picking up the slf4j libraries already given that the code uses them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message