curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <>
Subject [GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...
Date Mon, 11 Aug 2014 22:00:36 GMT
Github user Randgalt commented on a diff in the pull request:
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/
    @@ -469,6 +469,26 @@ private String protectedPathInForeground(String adjustedPath, byte[]
data) throw
                 throw e;
    +        catch ( KeeperException e )
    --- End diff --
    I think it would be cleaner because there a duplicated block of code now. Or, move the
duplicated code into a new method.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message