curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-67 defer creation of serializer
Date Mon, 04 Aug 2014 00:54:17 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/30#discussion_r15737880
  
    --- Diff: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceDiscoveryBuilder.java
---
    @@ -29,6 +29,7 @@
         private String                  basePath;
         private InstanceSerializer<T>   serializer;
         private ServiceInstance<T>      thisInstance;
    +    private Class<T>                payloadClass;
     
         /**
          * Return a new builder. The builder will be defaulted with a {@link JsonInstanceSerializer}.
    --- End diff --
    
    This comment about defaulting the serializer should be moved to the build() method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message