Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: dragonsinth <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-23-curator@git.apache.org>
In-Reply-To: <git-pr-23-curator@git.apache.org>
Subject: [GitHub] curator pull request: CURATOR-126: Fix race condition in
 CuratorFr...
Content-Type: text/plain
Message-Id: <20140728190733.BD71B9B8630@tyr.zones.apache.org>
Date: Mon, 28 Jul 2014 19:07:33 +0000 (UTC)

Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/23#discussion_r15483300
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -300,12 +295,20 @@ public Void apply(CuratorListener listener)
                 listeners.clear();
                 unhandledErrorListeners.clear();
                 connectionStateManager.close();
    +            if (backgroundThread != null) {
    +                backgroundThread.interrupt();
    +                try
    +                {
    +                    backgroundThread.join(1000);
    --- End diff --
    
    I totally made this number up.  What's the right thing here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---