Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52E1811072 for ; Fri, 25 Jul 2014 06:20:18 +0000 (UTC) Received: (qmail 24876 invoked by uid 500); 25 Jul 2014 06:20:18 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 24844 invoked by uid 500); 25 Jul 2014 06:20:18 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 24832 invoked by uid 99); 25 Jul 2014 06:20:17 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jul 2014 06:20:17 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 7D0129B3FA7; Fri, 25 Jul 2014 06:20:17 +0000 (UTC) From: cammckenzie To: dev@curator.apache.org Reply-To: dev@curator.apache.org References: In-Reply-To: Subject: [GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe Content-Type: text/plain Message-Id: <20140725062017.7D0129B3FA7@tyr.zones.apache.org> Date: Fri, 25 Jul 2014 06:20:17 +0000 (UTC) Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/17#issuecomment-50111927 Overall, looks really good. I've made a few minor comments. My only other comment would be that it would be nice to see some more unit tests specific to a multi level cache. It's good that the TreeCache works against all of the PathChildrenCache tests, but I could only see 1 test that specifically deals with data with a depth > 2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---