curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-42) Background guaranteed delete considers NoNode to be a failed delete, and retries it
Date Tue, 29 Jul 2014 22:11:40 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078483#comment-14078483
] 

ASF GitHub Bot commented on CURATOR-42:
---------------------------------------

GitHub user Randgalt opened a pull request:

    https://github.com/apache/curator/pull/24

    CURATOR-42 - Modified guaranteed delete handling so that it will only

    add the node to the guaranteed delete set if a recoverable exception is
    encountered. If a non recoverable exception (such as a NoNodeException)
    is encountered, then this will not be retried. Added a debug listener to
    the FailedDeleteManager to facilitate unit testing this case. Added unit
    tests, for both guaranteed deletes in the background and foreground for
    the NoNodeException case. Note that this error was only present for
    guaranteed deletes in the foreground.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/curator CURATOR-42

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit b174dfb145ebaea51bcd348cec950997725e7b3f
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2014-07-29T22:06:25Z

    CURATOR-42 - Modified guaranteed delete handling so that it will only
    add the node to the guaranteed delete set if a recoverable exception is
    encountered. If a non recoverable exception (such as a NoNodeException)
    is encountered, then this will not be retried. Added a debug listener to
    the FailedDeleteManager to facilitate unit testing this case. Added unit
    tests, for both guaranteed deletes in the background and foreground for
    the NoNodeException case. Note that this error was only present for
    guaranteed deletes in the foreground.

----


> Background guaranteed delete considers NoNode to be a failed delete, and retries it
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-42
>                 URL: https://issues.apache.org/jira/browse/CURATOR-42
>             Project: Apache Curator
>          Issue Type: Bug
>            Reporter: Shevek
>            Assignee: Jordan Zimmerman
>             Fix For: awaiting-response
>
>
> In delete(), NoNode should be a special case which succeeds instantly, and does not consider
the delete failed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message