curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe
Date Thu, 31 Jul 2014 22:59:48 GMT
Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/17#discussion_r15675387
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCacheEvent.java
---
    @@ -0,0 +1,126 @@
    +/**
    --- End diff --
    
    Glad you brought this up; it's a straight copy, I think the only changes are renaming
things like CHILD_ADDED -> NODE_ADDED.  I tried to consistently switch to "node" terminology
since nodes in the tree cache can be both parents and children (as opposed to PathChildrenCache).
 Also, I wasn't sure how weird it would be to have a TreeCache emitting PathChildrenCacheEvents.
    
    I do kind of like the idea of deprecating the old event interfaces and creating a new
one that can consistently surface events for all 3 caches.  Perhaps we could call it "CacheEvent"
and it would essentially look like TreeCacheEvent.  I think NodeCache would be especially
improved by this, since at the moment all it offers is a "nodeChanged" event.
    
    The caches could simply keep two lists of listeners and publish both new and old style
events.
    
    What do you think?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message