curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...
Date Mon, 28 Jul 2014 21:00:38 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/23#discussion_r15490376
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java
---
    @@ -239,6 +241,16 @@ public Builder connectionTimeoutMs(int connectionTimeoutMs)
             }
     
             /**
    +         * @param closeWaitMs time to wait during close to join background threads
    --- End diff --
    
    Sorry to be pedantic, but this would be better named "maxCloseWaitMs". 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message