curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...
Date Mon, 28 Jul 2014 19:47:39 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/23#discussion_r15485742
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
    @@ -770,9 +769,8 @@ private void backgroundOperationsLoop()
                         debugListener.listen(operationAndData);
                     }
                 }
    -            catch ( InterruptedException e )
    +            catch ( InterruptedException ignored )
                 {
    -                Thread.currentThread().interrupt();
    --- End diff --
    
    This is not correct. _Always_ re-set the interrupted state of threads. The break statement
exists the while condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message