curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <>
Subject [GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...
Date Mon, 28 Jul 2014 19:05:56 GMT
Github user dragonsinth commented on a diff in the pull request:
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/
    @@ -770,9 +769,8 @@ private void backgroundOperationsLoop()
    -            catch ( InterruptedException e )
    +            catch ( InterruptedException ignored )
    -                Thread.currentThread().interrupt();
    --- End diff --
    not necessary; also inconsistent with the while condition.  If the loop exits because
the while condition test reads the interrupted value, it's not resetting the interrupted flag
anyway, so there's no point doing it on this exit path either.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message