curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-33 recursive TreeCache recipe
Date Fri, 25 Jul 2014 06:20:17 GMT
Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/17#issuecomment-50111927
  
    Overall, looks really good. I've made a few minor comments. My only other comment would
be that it would be nice to see some more unit tests specific to a multi level cache. It's
good that the TreeCache works against all of the PathChildrenCache tests, but I could only
see 1 test that specifically deals with data with a depth > 2.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message