Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: cammckenzie <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-11-curator@git.apache.org>
In-Reply-To: <git-pr-11-curator@git.apache.org>
Subject: [GitHub] curator pull request: CURATOR-114 - Modified the
 TestingServer to ...
Content-Type: text/plain
Message-Id: <20140617214346.868EB981671@tyr.zones.apache.org>
Date: Tue, 17 Jun 2014 21:43:46 +0000 (UTC)

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/11#discussion_r13887642
  
    --- Diff: curator-test/src/main/java/org/apache/curator/test/TestingServer.java ---
    @@ -104,6 +171,17 @@ public void stop() throws IOException
         }
     
         /**
    +     * Restart the server. This is only valid if the server has previously been
    --- End diff --
    
    I agree, I was surprised that restart was really just 'start if you've been stopped before'. It doesn't look like any test cases are using this code at the moment, so I'll modify the restart() to do a stop() if it's running, followed by a start().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---