Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: cammckenzie <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-9-curator@git.apache.org>
In-Reply-To: <git-pr-9-curator@git.apache.org>
Subject: [GitHub] curator pull request: Curator 110
Content-Type: text/plain
Message-Id: <20140612222521.1847A8C3C01@tyr.zones.apache.org>
Date: Thu, 12 Jun 2014 22:25:21 +0000 (UTC)

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/9#discussion_r13730278
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -162,6 +166,21 @@ public void process(WatchedEvent watchedEvent)
     
             failedDeleteManager = new FailedDeleteManager(this);
             namespaceFacadeCache = new NamespaceFacadeCache(this);
    +        
    +        //Add callback handler to determine connection state transitions
    +    	getConnectionStateListenable().addListener(new ConnectionStateListener()
    --- End diff --
    
    We need to get updates on when the state changes, otherwise we'd need to keep polling the connectionStateManager for connection state changes. This is only needed if the blocking until connected logic is implemented in the CuratorFramework. If we use the CuratorZooKeeperClient instead, it can be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---