curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-114) TestingServer should expose restart() method.
Date Tue, 17 Jun 2014 21:31:23 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034403#comment-14034403
] 

ASF GitHub Bot commented on CURATOR-114:
----------------------------------------

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/11#discussion_r13886728
  
    --- Diff: curator-test/src/main/java/org/apache/curator/test/TestingServer.java ---
    @@ -104,6 +171,17 @@ public void stop() throws IOException
         }
     
         /**
    +     * Restart the server. This is only valid if the server has previously been
    --- End diff --
    
    Just following the current convention with the underlying TestingZookeeperServer. It throws
an exception if restart() is called on an instance that is not in a STOPPED state. Are you
suggesting that restart() should work from any state? Or just a LATENT or STOPPED state? Either
way, it would require changes to the TestingZookeeperServer, but I don't think that's inherently
a problem as the restart() method is only used by the TestingCluster, and I don't think modifying
the behaviour would cause issues there.
    



> TestingServer should expose restart() method.
> ---------------------------------------------
>
>                 Key: CURATOR-114
>                 URL: https://issues.apache.org/jira/browse/CURATOR-114
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 2.5.0
>            Reporter: Cameron McKenzie
>            Priority: Trivial
>
> Currently restarting the TestingServer involves:
> server.stop()
> server = new TestingServer(server.getPort(), server.getTempDirectory());
> The underlying Zookeeper testing server that is contained within TestingServer supports
a restart() method. It would be cleaner to expose this on the TestingServer interface, so
a restart would simply involve:
> server.restart()



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message