curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cameron McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-110) LeaderLatch does not complete if it is started without a connection to ZooKeeper
Date Tue, 17 Jun 2014 21:49:09 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034430#comment-14034430
] 

Cameron McKenzie commented on CURATOR-110:
------------------------------------------

Looks good Jordan. Not sure why (maybe because it's not a pull request?) but I can't comment
against the diff in the link above. There was one minor thing that I noticed (which I probably
wrote in the first place).

In the blockUntilConnected(int maxWaitTime, TimeUnit units) method, the maxWaitTimeMS is converted
into MS each time the loop iterates, when it could just be calculated once outside the loop.

> LeaderLatch does not complete if it is started without a connection to ZooKeeper
> --------------------------------------------------------------------------------
>
>                 Key: CURATOR-110
>                 URL: https://issues.apache.org/jira/browse/CURATOR-110
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.5.0
>            Reporter: Cameron McKenzie
>            Priority: Minor
>              Labels: connection, latch, leader
>             Fix For: 2.6.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Given the following conditions:
> 1.) No connection is available to ZK
> 2.) A LeaderLatch is created and started
> 3.) All retries for the leader latch creating its ephemeral zNode have been exhausted.
> At this point the LeaderLatch will not begin functioning correctly when a connection
is established. This is due to it ignoring 'CONNECTED' connection state events (it only handles
RECONNECTED events).
> The fix should simply be a case of making the state handling for CONNECTED and RECONNECTED
the same.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message