curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-114 - Modified the TestingServer to ...
Date Wed, 18 Jun 2014 04:15:36 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/11#discussion_r13898859
  
    --- Diff: curator-test/src/main/java/org/apache/curator/test/TestingServer.java ---
    @@ -37,47 +37,104 @@
     
         /**
          * Create the server using a random port
    -     *
    -     * @throws Exception errors
    +     * 
    +     * @throws Exception
    +     *             errors
          */
         public TestingServer() throws Exception
         {
    +        this(true);
    +    }
    +
    +    /**
    +     * Create the server using a random port
    +     * 
    +     * @param start
    +     *            True if the server should be started, false otherwise
    +     * @throws Exception
    +     *             errors
    +     */
    +    public TestingServer(boolean start) throws Exception
    --- End diff --
    
    Good point, yes it should be passed into the other constructor, will fix this up now.
    
    The start flag is not currently used in any of the unit tests, but I think that it's useful
to be able to create a server without starting it. There are cases where you want to start
with a server that is not started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message