curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-114 - Modified the TestingServer to ...
Date Tue, 17 Jun 2014 21:31:18 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/11#discussion_r13886728
  
    --- Diff: curator-test/src/main/java/org/apache/curator/test/TestingServer.java ---
    @@ -104,6 +171,17 @@ public void stop() throws IOException
         }
     
         /**
    +     * Restart the server. This is only valid if the server has previously been
    --- End diff --
    
    Just following the current convention with the underlying TestingZookeeperServer. It throws
an exception if restart() is called on an instance that is not in a STOPPED state. Are you
suggesting that restart() should work from any state? Or just a LATENT or STOPPED state? Either
way, it would require changes to the TestingZookeeperServer, but I don't think that's inherently
a problem as the restart() method is only used by the TestingCluster, and I don't think modifying
the behaviour would cause issues there.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message