curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <>
Subject [GitHub] curator pull request: Curator 110
Date Fri, 13 Jun 2014 01:09:13 GMT
Github user cammckenzie commented on the pull request:
    Ok, so what's the way forward? We can either refactor internalBlockUntilConnectedOrTimedOut()
in CuratorZooKeeperClient to allow arbitrary timeouts, and try to remove the 1 second sleep
increments. Or, we can move the wait logic to the CuratorFramework, and use the ConnectionStateListener.
    Assuming there's not technical reason why the CuratorZooKeeperClient can't block for arbitrary
lengths of time, then it's ok to implement there. I don't really have a strong preference
either way.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message