curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <>
Subject [GitHub] curator pull request: Curator 110
Date Fri, 13 Jun 2014 00:21:08 GMT
Github user Randgalt commented on a diff in the pull request:
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/
    @@ -210,4 +213,28 @@
          * @param watcher the watcher
         public void clearWatcherReferences(Watcher watcher);
    +    /**
    +     * Get the current connection state. The connection state will have a value of 0
    +     * the first connection related event is received.
    +     * @return The current connection state, or null if it is unknown 
    +     */
    +    public ConnectionState getCurrentConnectionState();
    +    /**
    +     * Block until a connection to ZooKeeper is available or the maxWaitTime has been
    +     * @param maxWaitTime The maximum wait time. Specify a value <= 0 to wait indefinitely
    +     * @param units The time units for the maximum wait time.
    +     * @return True if connection has been established, false otherwise.
    +     * @throws InterruptedException If interrupted while waiting
    +     */
    +    public boolean blockUntilConnected(int maxWaitTime, TimeUnit units) throws InterruptedException;
    --- End diff --
    Technically, there is a timeout. It's the connectionTimeout used when creating the CuratorFramework
instance. Is that not sufficient? If it's still needed, it seems better to push it down to
CuratorZookeeperClient with the other method.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message