curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 110
Date Thu, 12 Jun 2014 13:00:02 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/9#discussion_r13699616
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderLatch.java
---
    @@ -154,8 +166,30 @@ public void start() throws Exception
         {
             Preconditions.checkState(state.compareAndSet(State.LATENT, State.STARTED), "Cannot
be started more than once");
     
    -        client.getConnectionStateListenable().addListener(listener);
    -        reset();
    +        //Block until connected
    +        final ExecutorService executor = ThreadUtils.newSingleThreadExecutor("");
    +        executor.submit(new Runnable()
    --- End diff --
    
    This would be better as a utility ala RetryLoop.callWithRetry(). I can see this pattern
getting used in other places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message