curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 110
Date Tue, 03 Jun 2014 23:16:21 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/9#discussion_r13364526
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionState.java
---
    @@ -57,5 +57,15 @@
          * <a href="http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode">http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode</a>.
          * The connection will remain in read only mode until another state change is sent.
          */
    -    READ_ONLY
    +    READ_ONLY;
    +    
    +    /**
    +     * Check if this state indicates that Curator has a connection to ZooKeeper
    +     * 
    +     * @return True if connected, false otherwise
    +     */
    +    public boolean isConnected()
    +    {
    +        return this == CONNECTED || this == RECONNECTED || this == READ_ONLY;
    --- End diff --
    
    I'd prefer to see this as an abstract method and have each enum return the correct value


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message