curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 110
Date Tue, 03 Jun 2014 23:15:55 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/9#discussion_r13364513
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderLatch.java
---
    @@ -542,34 +542,21 @@ public void processResult(CuratorFramework client, CuratorEvent
event) throws Ex
     
         private void handleStateChange(ConnectionState newState)
         {
    -        switch ( newState )
    -        {
    -        default:
    -        {
    -            // NOP
    -            break;
    -        }
    -
    -        case RECONNECTED:
    +        if (newState.isConnected())
             {
                 try
                 {
                     reset();
                 }
    -            catch ( Exception e )
    +            catch (Exception e)
                 {
                     log.error("Could not reset leader latch", e);
                     setLeadership(false);
                 }
    -            break;
             }
    -
    -        case SUSPENDED:
    -        case LOST:
    +        else
    --- End diff --
    
    Hmm - this suggests that we should have an isLost() method in the ConnectionState no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message