Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: eceejcr <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-6-curator@git.apache.org>
In-Reply-To: <git-pr-6-curator@git.apache.org>
Subject: [GitHub] curator pull request: CURATOR-90
Content-Type: text/plain
Message-Id: <20140510231614.D4C9881C28E@tyr.zones.apache.org>
Date: Sat, 10 May 2014 23:16:13 +0000 (UTC)

Github user eceejcr commented on a diff in the pull request:

    https://github.com/apache/curator/pull/6#discussion_r12506742
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -72,6 +74,9 @@
         private final NamespaceWatcherMap                                   namespaceWatcherMap = new NamespaceWatcherMap(this);
     
         private volatile ExecutorService                                    executorService;
    +    private final AtomicBoolean                                         logAsErrorConnectionErrors = new AtomicBoolean(false);
    +
    +    private static final boolean                                        LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL = Boolean.getBoolean(DebugUtils.PROPERTY_LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL);
    --- End diff --
    
    Jordan I created it as a constant, but I am not sure if you were thinking to manipulate the property with code and therefore you prefer a more dynamic approach. Anyway looks simple the change. Let me know


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---