curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Lopashev (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CURATOR-108) Wrong usage of Arrays.equals in DistributedAtomicValue for values equality test
Date Thu, 22 May 2014 14:33:01 GMT
Alex Lopashev created CURATOR-108:
-------------------------------------

             Summary: Wrong usage of Arrays.equals in DistributedAtomicValue for values equality
test
                 Key: CURATOR-108
                 URL: https://issues.apache.org/jira/browse/CURATOR-108
             Project: Apache Curator
          Issue Type: Bug
          Components: Recipes
            Reporter: Alex Lopashev
            Priority: Critical


Without setting value ZooKeeper DistributedAtomicValue instance returns byte[0]{} as its value,
but in #compareAndSet method expectedValue is always non-zero-sized byte array, so in fresh
new DistributedAtomicValue with no data in ZooKeeper node test Arrays.equals(byte[4]{0,0,0,0},
byte[0]{}) for integer and Arrays.equals(byte[8]{0,0,0,0,0,0,0,0}, byte[0]{}) will always
fail. Solution is to not only check with Arrays.equals, but also if one of byte arrays is
empty then check if second one has only zero elements.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message