curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CURATOR-90) Reduce the verbosity of connection error log messages
Date Mon, 12 May 2014 02:56:16 GMT


ASF GitHub Bot commented on CURATOR-90:

Github user Randgalt commented on a diff in the pull request:
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/
    @@ -72,6 +74,9 @@
         private final NamespaceWatcherMap                                   namespaceWatcherMap
= new NamespaceWatcherMap(this);
         private volatile ExecutorService                                    executorService;
    +    private final AtomicBoolean                                         logAsErrorConnectionErrors
= new AtomicBoolean(false);
    +    private static final boolean                                        LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL
    --- End diff --
    This is fine, but I think the default should be TRUE so that we retain the previous behavior.
People who want the new behavior can set the property. What do you think?

> Reduce the verbosity of connection error log messages
> -----------------------------------------------------
>                 Key: CURATOR-90
>                 URL:
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 2.4.0
>            Reporter: Julio Lopez
>            Priority: Minor
>         Attachments: CURATOR-90.patch, curator-90-evaristo.patch
> On connection error, such as a network disconnection from the ZK cluster,  CuratorFrameworkImpl
does excessive logging.  While a system property, namely PROPERTY_DONT_LOG_CONNECTION_ISSUES
= "curator-dont-log-connection-problems", can be set to avoid filling out the logs with connection
error messages, this is an all or nothing setting.
> It is desirable to allow for less verbose logging that can be more easily controlled
and filtered using the logging framework of choice.

This message was sent by Atlassian JIRA

View raw message