curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-90) Reduce the verbosity of connection error log messages
Date Sat, 10 May 2014 23:17:14 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994328#comment-13994328
] 

ASF GitHub Bot commented on CURATOR-90:
---------------------------------------

Github user eceejcr commented on a diff in the pull request:

    https://github.com/apache/curator/pull/6#discussion_r12506742
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
    @@ -72,6 +74,9 @@
         private final NamespaceWatcherMap                                   namespaceWatcherMap
= new NamespaceWatcherMap(this);
     
         private volatile ExecutorService                                    executorService;
    +    private final AtomicBoolean                                         logAsErrorConnectionErrors
= new AtomicBoolean(false);
    +
    +    private static final boolean                                        LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL
= Boolean.getBoolean(DebugUtils.PROPERTY_LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL);
    --- End diff --
    
    Jordan I created it as a constant, but I am not sure if you were thinking to manipulate
the property with code and therefore you prefer a more dynamic approach. Anyway looks simple
the change. Let me know


> Reduce the verbosity of connection error log messages
> -----------------------------------------------------
>
>                 Key: CURATOR-90
>                 URL: https://issues.apache.org/jira/browse/CURATOR-90
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 2.4.0
>            Reporter: Julio Lopez
>            Priority: Minor
>         Attachments: CURATOR-90.patch, curator-90-evaristo.patch
>
>
> On connection error, such as a network disconnection from the ZK cluster,  CuratorFrameworkImpl
does excessive logging.  While a system property, namely PROPERTY_DONT_LOG_CONNECTION_ISSUES
= "curator-dont-log-connection-problems", can be set to avoid filling out the logs with connection
error messages, this is an all or nothing setting.
> It is desirable to allow for less verbose logging that can be more easily controlled
and filtered using the logging framework of choice.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message