curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tedpearson <...@git.apache.org>
Subject [GitHub] curator pull request: make ChildData constructor public for access...
Date Thu, 10 Apr 2014 18:55:50 GMT
GitHub user tedpearson opened a pull request:

    https://github.com/apache/curator/pull/4

    make ChildData constructor public for access from unit tests and such

    When unit testing an application making use of PathChildrenCache, I wanted to make some
PathChildrenCacheEvents to pass to my PathChildrenCacheListener-implementing class. However
I found that PathChildrenCacheEvent contains ChildData, which has only a no-modifier constructor,
meaning my unit test would have to be in the org.apache.curator.framework.recipies.cache package
in order to perform these tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedpearson/curator master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit 43d1c23762b9242d2ec31a2b7d34330ec0ef2b9a
Author: Ted Pearson <ted@addthis.com>
Date:   2014-04-10T18:51:15Z

    make ChildData constructor public for access from unit tests and such

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message