curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Curator 94
Date Sun, 09 Mar 2014 11:47:03 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/2#discussion_r10413488
  
    --- Diff: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceDiscoveryImpl.java
---
    @@ -146,7 +146,10 @@ public void close() throws IOException
         @Override
         public void registerService(ServiceInstance<T> service) throws Exception
         {
    -        services.put(service.getId(), service);
    --- End diff --
    
    This will prevent updateService for permanent services. Is that desirable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message