curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shevek (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-41) Curator masks/loses exception in LockInternals
Date Mon, 24 Feb 2014 17:28:22 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910538#comment-13910538
] 

Shevek commented on CURATOR-41:
-------------------------------

I've seen ALL my bugs actually happen. Every ticket I raise for you is something which has
actually bitten us in the arse, usually quite hard. In this case, I hit this issue, and had
to instrument ... something, I forget now, in order to discover and fix the actual underlying
issue, which was presumably CURATOR-42, since I raised that immediately afterwards.

> Curator masks/loses exception in LockInternals
> ----------------------------------------------
>
>                 Key: CURATOR-41
>                 URL: https://issues.apache.org/jira/browse/CURATOR-41
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>            Reporter: Shevek
>             Fix For: TBD
>
>
>     private boolean internalLockLoop(long startMillis, Long millisToWait, String ourPath)
throws Exception
>         try {
>         ...
>         }
>         catch ( Exception e )
>         {
>             doDelete = true;
>             throw e;
>         }
>         finally
>         {
>             if ( doDelete )
>             {
>                 deleteOurPath(ourPath);
>             }
>         }
> Say ... throws an exception. catch sets doDelete = true. Then deleteOurPath throws an
exception. We never find out what the original exception was that caused the mutex to fail.
> In JDK8, I think we get the extra Throwable#getSuppressed() call, which will return us
this extra exception, but we aren't on JDK8 yet.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message