Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
Date: Wed, 27 Nov 2013 03:35:38 +0000 (UTC)
From: "Orcun Simsek (JIRA)" <jira@apache.org>
To: dev@curator.incubator.apache.org
Message-ID: <JIRA.12681494.1385522764059.35952.1385523338043@arcas>
In-Reply-To: <JIRA.12681494.1385522764059@arcas>
References: <JIRA.12681494.1385522764059@arcas>
Subject: [jira] [Comment Edited] (CURATOR-79) InterProcessMutex doesn't
 clean up after interrupt
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833414#comment-13833414 ] 

Orcun Simsek edited comment on CURATOR-79 at 11/27/13 3:34 AM:
---------------------------------------------------------------

Also adding a test that fails.
{code:title=Test.java|borderStyle=solid}
@Test
public void testInterruptDeadlock() throws Exception {
    CuratorFramework client = CuratorFrameworkFactory.builder()
        .connectString("127.0.0.1:2181")
        .retryPolicy(new RetryNTimes(10, 1000))
        .build();
    client.start();

    Thread.currentThread().interrupt();
    final InterProcessMutex lock = new InterProcessMutex(client, "/testInterruption");

    try {
        lock.acquire();
        lock.release();
     } catch (InterruptedException e) {
        if (lock.isAcquiredInThisProcess()) {
            lock.release();
        }
    }

    assertTrue(lock.acquire(10, TimeUnit.MILLISECONDS));
}
{code}


was (Author: ortschun):
Also adding a test that fails.
{code:title=Test.java|borderStyle=solid}
@Test
public void testInterruptDeadlock() throws Exception {
    CuratorFramework client = CuratorFrameworkFactory.builder()
        .connectString("127.0.0.1:2181")
        .retryPolicy(new RetryNTimes(10, 1000))
        .build();
    client.start();

    Thread.currentThread().interrupt();
    final InterProcessMutex lock = new InterProcessMutex(client, "/testInterruption");

    try {
        lock.acquire();
        lock.release();
     } catch (InterruptedException e) {
        e.printStackTrace();
        if (lock.isAcquiredInThisProcess()) {
            lock.release();
        }
    }

    assertTrue(lock.acquire(10, TimeUnit.MILLISECONDS));
}
{code}

> InterProcessMutex doesn't clean up after interrupt
> --------------------------------------------------
>
>                 Key: CURATOR-79
>                 URL: https://issues.apache.org/jira/browse/CURATOR-79
>             Project: Apache Curator
>          Issue Type: Bug
>            Reporter: Orcun Simsek
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>
> If the current thread is interrupted while acquiring the InterProcessMutex, a new node for the lock is created, InterruptException is thrown, and node is not deleted afterwards. Thus causing a deadlock.
> Curator should check the Interrupted state, and do the proper clean up.
> This issue was also discussed on: https://groups.google.com/forum/#!topic/curator-users/9ii5of8SbdQ


--
This message was sent by Atlassian JIRA
(v6.1#6144)