curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Zimmerman <jor...@jordanzimmerman.com>
Subject Re: CURATOR-2 branch
Date Wed, 31 Jul 2013 19:43:03 GMT
Sorry - I forgot to set you as a committer in Jira. You should have permission now.

-JZ

On Jul 31, 2013, at 10:41 AM, Ioannis Canellos <iocanel@gmail.com> wrote:

> Jordan,
> 
> I pushed to master, but I don't seem to have karma on jira for resolving
> the issue.
> As I am about to send out the vote email for 2.2.0-incubating, would it be
> easy for you to resolve the issue and create updated release notes that I
> can include in the vote email?
> 
> Thanks in advance.
> 
> 
> On Wed, Jul 31, 2013 at 6:21 PM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
> 
>> I understand. I don't have any experience with this so I'll trust your
>> judgement. +1 from me to push this.
>> 
>> -JZ
>> 
>> On Jul 31, 2013, at 8:19 AM, Ioannis Canellos <iocanel@gmail.com> wrote:
>> 
>>> A bundle is a normal jar, which contains some additional metadata inside
>>> its MANIFEST.MF that describe the requirements and capabilities of the
>> jar
>>> (usually required and expose packages). This has absolutely no-effect to
>>> non-OSGi users (these OSGi metadata are just ignored).
>>> 
>>> Regarding the bundle packaging, its just a way to let the
>>> maven-bundle-plugin know that we want it to generate a MANIFEST for us.
>>> It's harmless, it doesn't affect the release, it doesn't affect dependant
>>> projects, it doesn't really cause any kind of issues.
>>> 
>>> If you still have second thoughts about it, we can remove the packaging
>>> element and add some extra maven-plugin configuration to force the
>> manifest
>>> goal of the maven-bundle-plugin & some maven-jar-plugin config to embed
>> the
>>> generated MANIFEST.
>>> 
>>> I clearly prefer the bundle packaging for 2 reasons:
>>> 
>>> i) It requires less maven plugin configuration.
>>> ii)  A user can tell that curator is OSGi-ready just by looking at the
>> pom,
>>> without having to search deep into the pom.
>>> 
>>> --
>>> *Ioannis Canellos*
>>> *
>>> 
>>> **
>>> Blog: http://iocanel.blogspot.com
>>> **
>>> Twitter: iocanel
>>> *
>> 
>> 
> 
> 
> -- 
> *Ioannis Canellos*
> *
> 
> **
> Blog: http://iocanel.blogspot.com
> **
> Twitter: iocanel
> *


Mime
View raw message